search

binsync / libbs

A library for writing plugins in any decompiler: includes API lifting, common data formatting, and GUI abstraction!
BSD 2-Clause "Simplified" License
63 stars 4 forks source link

Adding Struct Deletion Using the del Keyword #87

Closed Flipout50 closed 2 months ago

Flipout50 commented 2 months ago

This adds functionality to the ArtifactDict of Structs that allows us to do something like del deci.structs['struct_name'] and have the respective decompiler remove the struct supplied as well as call the struct_changed callback with deleted=True. Also the skeleton for similar functionality of other Artifacts is added to the DecompilerInterface to be implemented whenever.

Flipout50 commented 2 months ago

@mahaloz So this PR adds new features but they are added for a bug fix, so would I increment the libbs version to 1.10.2 or 1.9.3. I was thinking 1.10.2 because its a new feature for libbs, but its being used to patch a bug in binsync, so i think it would be update the minor version for libbs but the patch number on binsync

Flipout50 commented 2 months ago

Also I can try to add struct del for binja but I couldn't really test it