search

bintray / gradle-bintray-plugin

Apache License 2.0
1.28k stars 197 forks source link

Switch dependencies #319

Closed aalmiray closed 4 years ago

aalmiray commented 4 years ago

Fix for #318

eyalbe4 commented 4 years ago

Thanks for this contribution @aalmiray! Can you please join our contributors community by signing JFrog's CLA so that we can merge your code?

aalmiray commented 4 years ago

Thanks for having a look at this. Just signed the CLA.

eyalbe4 commented 4 years ago

Thanks @aalmiray! I merged this PR. I noticed that the tests are failing with the following exception:

    Caused by: java.lang.NoClassDefFoundError: org/apache/maven/project/MavenProject
        at com.jfrog.bintray.gradle.Utils.readArtifactIdFromPom(Utils.groovy:46)
        at com.jfrog.bintray.gradle.Utils$readArtifactIdFromPom$1.call(Unknown Source)
        at com.jfrog.bintray.gradle.tasks.BintrayUploadTask.collectArtifacts(BintrayUploadTask.groovy:494)
        at com.jfrog.bintray.gradle.tasks.BintrayUploadTask$_bintrayUpload_closure1.doCall(BintrayUploadTask.groovy:201)
        at com.jfrog.bintray.gradle.tasks.BintrayUploadTask.bintrayUpload(BintrayUploadTask.groovy:197)

This is because of the removal of:

compile('org.apache.maven:maven-ant-tasks:2.1.3')

I'm therefore adding it back on top of this merge. Can you please retest this with this addition? Thanks!