search

binusgdc / VCPA

A Discord bot that records voice call participants' attendance
2 stars 4 forks source link

Output is using the wrong locale #9

Closed 500-internal-server-error closed 3 years ago

500-internal-server-error commented 3 years ago

This issue packs several changes that need to be made into a single general issue. The bot currently uses a mixture of locale formats, however it has been determined that it is best to use a single locale format, id-ID. This involves:

  1. Changing time zones to UTC+7.
  2. Changing decimal separators to be commas (e.g. 0,995)
  3. Changing outputs to be semicolon delimited (e.g. 255;0,99;other)

These changes would lead to a better future maintenance experience.

MrMissx commented 3 years ago

How about implementing a container with docker to isolate the timezones? So, no need to set a locale manually on code

500-internal-server-error commented 3 years ago

A docker container would be a nice addition to have better control of the execution environment. The bot can then simply use local time.

500-internal-server-error commented 3 years ago

A partial fix has been made by updating server timezone. Decimal separators and the accompanying changes to the csv format have yet to be updated.

500-internal-server-error commented 3 years ago

It has been determined that decimal separator changes are unnecessary. This issue has therefore been solved.