Custom notification channels

binwiederhier / ntfy-android

Android app for ntfy.sh

Apache License 2.0

465 stars 92 forks source link

Custom notification channels #49

Closed binwiederhier closed 1 year ago

binwiederhier commented 1 year ago

@doits I made two changes (mainly in https://github.com/binwiederhier/ntfy-android/pull/49/commits/f327c8ffddbd4ef9e0c4d5b0ac43ee04f4582481)

Removed the "scope" and just used "group". Is there any reason why these two variables were split? They seem to serve the same purpose. I realized that only after I looked at that in detail.
Used displayName and updated accordingly

Still TODO:

[x] Show/Hide the channels setting based on Android version (hide for older versions)
[x] Better UI description and names. It's not intuitive what that means
[x] Merge with the "insistent alerts" PR (this will be a nightmare)
[ ] ~Backup/restore~

doits commented 1 year ago

Removed the "scope" and just used "group". Is there any reason why these two variables were split?

I think you are right, since every subscription channel is always created for a group (default or dedicated for subscription), there is no need to split it up.

Used displayName and updated accordingly

That was easier than I thought :-)

Show/Hide the channels setting based on Android version

You probably don't need the help, but I found it on stack overflow :-) https://stackoverflow.com/a/45192258

Thanks for taking it over from me and glad I could bring this forward.

binwiederhier commented 1 year ago

IMHO, this branch is now complete. I merged the "insistent alerts" in, because it was so related that it conflicted a lot. I'll merge this branch once the Google Play stuff is resolved ...

binwiederhier commented 1 year ago

@doits Feel free to review!