search

binwiederhier / ntfy-android

Android app for ntfy.sh
Apache License 2.0
540 stars 112 forks source link

Add Unread Divider #60

Open thgoebel opened 1 year ago

thgoebel commented 1 year ago

This PR adds a divider after the unread messages. Just like in messaging apps.

The exact string ("You are all caught up!") is open for discussion. Maybe something more translation-friendly. E.g. Slack on iOS has "You're up-to-date :tada:" when you scroll up. Signal has "1 Unread Message".

Also, the string is hardcoded in XML right now because I don't know how your string/translation workflow works. I'll leave it to you to properly integrate it into the string setup.

binwiederhier commented 1 year ago

Wow. This is from June and I haven't commented or merged. My apologies. I haven't worked on the Android app in a while. When I do, I'll certainly look at this and/or merge it. Looks very neat. Thank you for your contribution!!

thgoebel commented 1 year ago

No problem! I’m running my fork, so I already have the unread divider and am happy :)