search

binwiederhier / ntfy-android

Android app for ntfy.sh
Apache License 2.0
507 stars 104 forks source link

Mark text input as not autofillable #8

Closed wilt00 closed 2 years ago

wilt00 commented 2 years ago

This PR fixes a bug I've encountered on my device, a Chromebook Duet tablet. When the device is in tablet view, without the physical keyboard attached, tapping into this "Topic name" text field seems to trip the autofill heuristic, making Android think this text field is a password input, so it pops up the user's password manager to show a prompt. This results in the user being blocked from typing into the text field using the onscreen keyboard:

(Screenshot taken in desktop mode, with the physical keyboard attached, because I haven't been able to figure out a way to take screenshots in tablet mode)

Since this textbox is not a password, and also not any of these field types (username, credit card, address, etc.), I figure it should be safe to block autofill for this field.

binwiederhier commented 2 years ago

Oh wow what an odd bug. Thank you for reporting and fixing it.