binwiederhier / ntfy

Send push notifications to your phone or desktop using PUT/POST
https://ntfy.sh
Apache License 2.0
18.54k stars 729 forks source link

Homepage / -- loads then crashes entire page, when GitHub API call returns 403 #1217

Open mcint opened 2 weeks ago

mcint commented 2 weeks ago

:lady_beetle: Describe the bug For the https://ntfy.sh homepage, and not on the Notifications / Subscriptions / Message-sending page, for unknown reasons I temporarily exceeded limits api.github.com.

While ntfy.sh requested https://api.github.com/repos/binwiederhier/ntfy, I presume for the live Stars count, the homepage would flash as loaded, then report a total crash. The api requests were receiving 403 reponses, {"message":"API rate limit exceeded for [ip]. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}.

I would be nice the the homepage gracefully degraded and was still usable, when dependencies are returning non-success statuses.

:computer: Components impacted Web homepage, ntfy.sh. Not the web app.

:bulb: Screenshots and/or logs

:crystal_ball: Additional context