wunter8
commented
1 week ago Wow! Thanks for working on this! Having message templates on the server is one of the features we talked about in the past, but obviously we haven't implemented it yet.
Binwiederhier will be the one to decide whether to merge this, but here are some of my thoughts:
- It's great that this is backwards-compatible
- I don't love that the feature is all or nothing: title and message both online or both server templates. I'm thinking mostly for titles, which are typically short and might not even depend on the contents of the JSON body. For example, having to create a file on the server just to have a title with "New Grafana Alert" (or any other fixed string) would be unfortunate.
I don't know the best way to remedy this, though. I considered something like tpl=server,inline for a server message and inline title. Or tpl=1&message=server:grafana&title=New+Grafana+Alert. Looking toward the future, though, we have discussed making it possible to template all message fields (such as priority and tags) based on the JSON body. I don't know what that looks like and how it combines with this.
- I don't use Golang very much. I saw some different styles between your code and the existing ntfy code. Not sure which is better 🤷♂️
- You seemed to do a good job adding additional tests while keeping the existing template tests 👍
- Thanks for keeping security concerns in mind like path traversals!
instead of sending title/message templates as part of the publishing request, systems can simply reference existing templates from the server. this has two advantages a) publish URLs become shorter b) publish URLs become easier to reuse
the changes backwards-compatible, as the
tplparameter continues to support truthy boolean values. the feature has to be enabled on the server. available templates and their content are exposed via new API endpoints.