binwiederhier / ntfy

Send push notifications to your phone or desktop using PUT/POST
https://ntfy.sh
Apache License 2.0
18.19k stars 711 forks source link

Android 13 Notification Icon invisible against the background #480

Closed s-h-a-r-d closed 1 year ago

s-h-a-r-d commented 1 year ago

tempFileForShare_20221109-121817

Device: Samsung Galaxy S22 Plus OS: Android 13

My device updated to Android 13 and now the background color of the notification icon is same as the icon color itself. Which makes the icon almost invisible.

I guess the background color is configured somewhere and could be changed to a different color. BUT I think changing the notification icon to be fully white could be a better solution.

clmbmb commented 1 year ago

Related to the above:

Before upgrading to Android 13 (Samsung Galaxy S20+) the notification icon in the status bar was 'adaptable', white on dark background, black on light background.

At the moment the icon is green and stays green in both situations. I'm attaching screenshots.

Screenshot_20221114_090614_Settings

Screenshot_20221114_090555_Settings

s-h-a-r-d commented 1 year ago

I can confirm the "always green" icon as well.

binwiederhier commented 1 year ago

I have not been able to reproduce either case in the emulator, but it occurs on my phone as well. Very odd.

alexhorner commented 1 year ago

I have not been able to reproduce either case in the emulator, but it occurs on my phone as well. Very odd.

I too have this issue on my S22. I think (from my limited android dev experience, so please dismiss me if you know better) that you can set various different icon types in some kind of manifest, and provide them as a bunch of resources, some of those resources intentionally being monochrome icons for situations such as these.

image

As you can see, FitnessSyncer also has this issue partially, but they don't appear to have a theme colour set. The other apps such as Automate have monochrome icons correctly configured so do not exhibit this issue.

binwiederhier commented 1 year ago

Should be fixed in https://github.com/binwiederhier/ntfy-android/pull/46 - Please try out the .apk and let me know if it works for you, and maybe post a screenshot too.

@alexhorner @s-h-a-r-d @clmbmb

NOTE: Be sure to back up your config first (Settings -> Backup)

https://drive.google.com/file/d/12Q9mejiBP1EZ84OFjvHyyPPoAklkTBPd/view?usp=share_link

alexhorner commented 1 year ago

@binwiederhier All tested, looking snazzy!

Screenshot_20221126_201534_Nova7.jpg

May I also make the recommendation that you configure the subscription service notification category to be minimised by default? As you can see in my screenshot, I have manually configured it to be minimised.

Thanks for your awesome work!

EDIT: And maybe make that notification also undismissable?

binwiederhier commented 1 year ago

May I also make the recommendation that you configure the subscription service notification category to be minimised by default?

I briefly checked and I don't think this can be toggled programatically.

EDIT: And maybe make that notification also undismissable?

You mean make it so that it can be swiped away? That's not possible for foreground service notifications. It's desired behavior in Android.

binwiederhier commented 1 year ago

Done. Will be in the next release.

alexhorner commented 1 year ago

May I also make the recommendation that you configure the subscription service notification category to be minimised by default?

I briefly checked and I don't think this can be toggled programatically.

Quasseldroid, Conversations and Automate as you can see in my screenshots have it minimised by default. I believe Quasseldroid and Conversations are open source so maybe that could be of help?

EDIT: And maybe make that notification also undismissable?

You mean make it so that it can be swiped away? That's not possible for foreground service notifications. It's desired behavior in Android.

The opposite. Both Quasseldroid and Automate are undismissable (cannot be swiped away). Conversations and ntfy both are dismissable (can be swiped away) right now, and don't seem to reappear without killing them and starting them again.

I will open a separate issue for this.

binwiederhier commented 1 year ago

Interesting. Yeah please feel free to create two new issues for this.