binwiederhier / ntfy

Send push notifications to your phone or desktop using PUT/POST
https://ntfy.sh
Apache License 2.0
18.66k stars 734 forks source link

Inform the client if it subscribes to a new topic #979

Open karmanyaahm opened 11 months ago

karmanyaahm commented 11 months ago

Deployment I think the Android app needs to be released first, before the server is deployed, so the client can deal with the case of re-registration on 404.

Paired with https://github.com/binwiederhier/ntfy-android/pull/70 Closes https://github.com/binwiederhier/ntfy/issues/664

codecov-commenter commented 11 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 82.60870% with 4 lines in your changes missing coverage. Please review.

Project coverage is 65.85%. Comparing base (bb4b5d2) to head (ec79778). Report is 172 commits behind head on main.

Files Patch % Lines
server/server.go 55.55% 3 Missing and 1 partial :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #979 +/- ## ========================================== + Coverage 65.82% 65.85% +0.02% ========================================== Files 53 53 Lines 7737 7746 +9 ========================================== + Hits 5093 5101 +8 - Misses 1799 1801 +2 + Partials 845 844 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.