search

binxio / cfn-custom-provider-template

template source directory for creating AWS Custom CloudFormation Resources in Python
Apache License 2.0
3 stars 4 forks source link

Don't Commit Pipfile.lock? #4

Open ambsw-technology opened 4 years ago

ambsw-technology commented 4 years ago

I had never heard of pipenv but recently ran into an issue. I updated my upstream (fork) of cfn-resource-provider but didn't know to rerun pipenv lock so I was troubleshooting an issue that was fixed in upstream but frozen (on a broken version) in my Pipfile.lock. It seems to me that you wouldn't, in general, want to do this in the repo because it would prevent your package from ever picking up upstream fixes of any sort. The first time you make test, it should be generated and provide stability from that point forward.

ambsw-technology commented 4 years ago

It's even possible that I made a change to the Pipfile but not the requirements.txt (which appear to control).