binxio / cfn-secret-provider

A CloudFormation custom resource provider for deploying secrets and keys
Apache License 2.0
141 stars 70 forks source link

Broken v1.0.0 #29

Closed dalibor-aleksic-atomia closed 5 years ago

dalibor-aleksic-atomia commented 5 years ago

Stack stucks in CREATE_IN_PROGRESS state

AWSTemplateFormatVersion: "2010-09-09"
Description: >-
  Test Stack
Resources:
  DBPassword:
    Type: Custom::Secret
    Properties:
      Name: /test/DBPassword/PGPASSWORD
      KeyAlias: alias/aws/ssm
      Alphabet: abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789
      Length: 30
      ReturnSecret: true
      ServiceToken: !Sub 'arn:aws:lambda:${AWS::Region}:${AWS::AccountId}:function:binxio-cfn-secret-provider'

Checked CloudWatch logs for lamba function and found error log:

Runtime.HandlerNotFound: Handler 'handler' missing on module 'secrets'

Deployed v0.13.3 and everything went smooth

mvanholsteijn commented 5 years ago

@dalibor-aleksic-atomia, the v1.0.0 provider and demo work. I suspect that you updated the provider version, but not the lambda runtime. V1.0.0 requires the Python3.7 runtime.

dalibor-aleksic-atomia commented 5 years ago

It was a fresh provider install/deploy. Currently, I'm using the older version, but I will try again with the new version and post results here...

mvanholsteijn commented 5 years ago

Oke. I will close the issue for now. Please reopen if the problem reappears.