binxio / cfn-secret-provider

A CloudFormation custom resource provider for deploying secrets and keys
Apache License 2.0
141 stars 70 forks source link

Use boto3 ec2.create_key_pair() function #41

Closed bisoldi closed 3 years ago

bisoldi commented 3 years ago

Is there a reason you're using the python cryptography package to create the RSA key rather than using the boto3 create_key_pair function in the EC2 module?

Is it simply to allow customizing the keysize?

mvanholsteijn commented 3 years ago

The secret provider is capable of generating several types of private keys, so for consistency I used the Python cryptography package.