search

binxio / cfn-secret-provider

A CloudFormation custom resource provider for deploying secrets and keys
Apache License 2.0
141 stars 70 forks source link

cleanup on delete #53

Closed cnpeyt closed 11 months ago

cnpeyt commented 3 years ago

I'm not sure if this is bug or not. I'm using Custom::RSAKey to generate a public/private key pair, the private key is being written to SSM parameter store. When I deleted the stack, the SSM param that was created to store the private key was not removed. Should the resource on cleanup in turn remove the SSM param as well?

mvanholsteijn commented 3 years ago

The ssm parameter in which the key is stores should be deleted. Did the delete fail for some reason? The provider tends to ignore errors on delete.

cnpeyt commented 3 years ago

So I don't know what happened for sure. I deleted the stack and I thought everything was removed successfully. I noticed later that the SSM param for the private key still existed. I'll try again this week and see if can reproduce.