binyamolango / recipe_app2

An app that keeps track of all users' recipes and ingredients. It will allow the user to save ingredients, keep track of what they have, create recipes, and generate a shopping list based on what the user have and missing from a recipe. Built with Ruby on Rails and Postgres.
https://edenic-recipe-i1dt.onrender.com/
MIT License
1 stars 0 forks source link

Setup kanban board #11

Closed binyamolango closed 7 months ago

binyamolango commented 7 months ago

Hi Reviewer ๐Ÿ‘‹

thecodechaser commented 7 months ago

STATUS: CHANGES REQUIRED โ™ป๏ธ

Hi @binyamolango, and @Ochiengsteven๐Ÿ‘‹,

Good job so far! There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes โ™ป๏ธ

image

image

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider: N/A

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

skyv26 commented 7 months ago

Hi Team,

Great work on making the changes requested by a previous reviewer ๐Ÿ‘ You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

STATUS: REQUIRE CHANGES ๐Ÿ”ด

Highlights

Required Changes โ™ป๏ธ

Have any doubt โ“

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag @skyv26 in your question so I can receive the notification. You can also follow me on the below platforms

@skyv26 linkedin-skyv2022 @vrma_aakash @skybrel @skybrel

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Ibizugbe commented 7 months ago

Hi @Team๐Ÿ‘‹๐Ÿผ๐Ÿ‘‹๐Ÿผ๐Ÿ‘‹๐Ÿผ,

approved

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit: Congratulations! ๐ŸŽ‰

Highlightsโœ…โœ…โœ…

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!๐Ÿ‘๐Ÿ‘๐Ÿ‘

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.