search

binygal / jest-runner-flowtype

Jest runner for running flowtype tests using jest as a platform
26 stars 10 forks source link

fix windows hang #11

Closed Klathmon closed 6 years ago

Klathmon commented 6 years ago

This is the second attempt of fixing the windows hang, this time with 80% less git mistakes.

It runs the command in a separate shell and passes in the env. This will make exec use whatever shell is setup in the %COMSPEC% env var correctly for both the main process, and all subprocesses.

Before this, the main exec would inherit the shell it's run in, but sub-processes would default to using cmd.exe since the %COMSPEC% env var wasn't available, leading to a possible mismatch in the shells that the parent and children were using, which i'm fairly certain would cause the hang.

binygal commented 6 years ago

Thank you for cleaning this PR 😄. Please take a look at my other comment.