search

bio-learn / biolearn

Machine learning tools for biomarker analysis
Other
44 stars 14 forks source link

Added 12 new biomarkers #73

Closed albert-ying closed 5 months ago

albert-ying commented 5 months ago

@sarudak I encountered errors for two new biomarkers, HepatoXu and AD_Bahado-Singh. I left the error message as a comment in the model.py and temporarily marked them as "NotImplemented." Could you take a look at it? Thank you!

sarudak commented 5 months ago

You issue with HepatoXu is probably related to parsing. My editor noticed that the "-" is not the expected symbol. I think this is causing it to be parsed as a string and not a number.

image

The issue with AD_Bahado-Singh is caused by the imputation failing if missing cpg is not in the reference set. I think I will change that to a warning but simply setting imputation_method="none" or "averaging" will resolve this error.