bio-ontology-research-group / unit-ontology

An ontology of units of measurements
Creative Commons Attribution 4.0 International
19 stars 12 forks source link

NTRs for HIPC Data Coordinating Center #68

Open rvita opened 1 year ago

rvita commented 1 year ago

Hi, I have a set of new terms that I want to request for the Human Immunology Project Consortium (HIPC) Data Coordinating Center (HCC). Let me know if you'd rather I use a template or separate each term into its own ticket. Some are straight forward, but some may be out of scope or require more information from me. The terms are: picogram per milliliter microgram per milliliter microgram per microliter percentage cell count milligram per deciliter Mean Fluorescence Intensity (MFI) titer threshold cycle (or Ct or Cq) beats per minute multiplicity of infection (MOI) grade breaths per minute Thank you, Randi

reality commented 1 year ago

Hello, thanks for this request. Could you please provide descriptions for these measurements? I also wonder if you are aware of the CMO ontology, which may also suit some of your needs for annotation of clinical measurements!

rvita commented 1 year ago

sorry for the delay, we did not realize you had replied. we will get back to you asap.

reality commented 1 year ago

Thanks a lot! Will keep an eye on the thread so I can implement the terms quickly! Apologies again for the initial slow response.

sebastianduesing commented 1 year ago

Hi, here's a sheet of proposed definitions from our team. We've taken a few off the original list that we think should go to other ontologies. Please let us know if you have any questions/concerns about any of these! I'd also be happy to submit a pull request for these if that'd be helpful. Thanks!

reality commented 1 year ago

Thank you, have added most of the classes:

picogram per milliliter | UO:0010070 microgram per milliliter | UO:0000274 microgram per microliter | UO:0010072 cell count | UO:0010073 milligram per deciliter | UO:0010067 heartbeats per minute | UO:0010074 multiplicity of infection | UO:0010075 breaths per minute | UO:0010076 PCR quantification cycle | UO:0010077 Mean Fluorescence Intensity | not a unit Median Fluorescence Intensity | not a unit titer | UO:0010080

I would also say that cell count, BPM, brpm, and possibly titer are also measures rather than units, and should probably be sourced in CMO (or elsewhere instead). I will look for alternatives and potentially remove them before release

sebastianduesing commented 1 year ago

Thank you! We understand about MFI (and possibly cell count, BPM, BRPM, and titer) not falling within the scope of this ontology, and we'll look for alternatives as well, in case you decide it is best to remove any of those prior to release.

We've found one more term in our data which seems like it would be appropriate for UO, the International Unit (IU), which I've added to the spreadsheet linked above. If you'd like me to open a separate issue for that one, just let me know, and I'll do so. Thanks again for your help.