search

bio-routing / bio-rd

bio routing is a project to create a versatile, fast and reliable routing daemon in Golang. bio = BGP + IS-IS + OSPF
Apache License 2.0
283 stars 44 forks source link

ris-mirror: Add API for removing one or all vrf ris clients at runtime #430

Closed margau closed 1 year ago

margau commented 1 year ago

When using the ris-mirror API, it was only possible to add new VRFs, but not remove vrfs from the ris-mirror at runtime. This leads to problems when for example an vrf/router is not available any longer, but cannot be removed from the ris-mirror, leading to failing observeRIB calls. This PR adds basic support for gracefully removing an router/VRF at runtime.

codecov-commenter commented 1 year ago

Codecov Report

Merging #430 (8b58d65) into master (299db46) will not change coverage. The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##           master     #430   +/-   ##
=======================================
  Coverage   54.03%   54.03%           
=======================================
  Files         147      147           
  Lines        7963     7963           
=======================================
  Hits         4303     4303           
  Misses       3455     3455           
  Partials      205      205
Flag Coverage Δ
unittests 54.03% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

margau commented 1 year ago

Hi @taktv6, do you have an update on this PR?