search

bio-routing / bio-rd

bio routing is a project to create a versatile, fast and reliable routing daemon in Golang. bio = BGP + IS-IS + OSPF
Apache License 2.0
283 stars 44 forks source link

net/tcp: use SetsockoptTCPMD5Sig from golang.org/x/sys/unix #436

Closed tklauser closed 1 year ago

tklauser commented 1 year ago

Use the TCPMD5Sig type and its corresponding SetsockoptTCPMD5Sig helper added in x/sys v0.6.0 to set the TCP MD5 sig on a socket.

taktv6 commented 1 year ago

LGTM. Did you conduct a practical test of this?

tklauser commented 1 year ago

LGTM. Did you conduct a practical test of this?

I did test unix.SetsockoptTCPMD5Sig, but not on bio-rd specifically so far.

taktv6 commented 1 year ago

I just ran a test against a Junos device. Works as expected. Thanks for contributing!