bio-tools / biotoolsRegistry

biotoolsregistry : discovery portal for bioinformatics
GNU General Public License v3.0
70 stars 20 forks source link

Link previews are inconsistent - angular not processed for most link previews. #552

Closed hexylena closed 4 weeks ago

hexylena commented 2 years ago

Hey y'all

link previews (e.g. as on twitter, matrix, etc.) seem to currently show relatively useless link previews in most places, due to the use of angular properties which are not resolved until javascript runs. Most link preview generators will only look at the HTML and not execute javascript, so replacing the following with their static alternatives would be useful:

    <meta name="description" content="{{ngMeta.description}}" />
    <meta property="og:title" content="{{ngMeta['og:title']}}" />
    <meta property="og:description" content="{{ngMeta['og:description']}}" />
    <meta property="og:image" content="{{ngMeta['og:image']}}" />

If you all would be up for filling those out statically (or at build time) it would result in a better user experience, I think!

Matrix Twitter Telegram
image nothing image
hansioan commented 2 years ago

@hexylena You are right that JavaScript needs to run to resolve those values. However we have a server side generated page which is being served to robots, perhaps we're missing some. I know the previews work on Slack for example

bio tools preview slack

So it doesn't work on Twitter and Matrix?

hexylena commented 2 years ago

Ahh interesting, ssr. That makes sense. Then yes, it's just matrix and twitter I think.