bio2bel / expasy

A Bio2BEL package for converting ExPASy to BEL
MIT License
0 stars 0 forks source link

Code style: Rename arguments #10

Closed cthoyt closed 6 years ago

cthoyt commented 6 years ago

More specific variable names can help us better understand what the function does, even without reading the documentation. Since the following functions all have fields called _id that refer to the expasy_id, it would be easier to understand if it was replaced to be explicit.

https://github.com/bio2bel/ec/blob/ba377388b0d3fe018b6826e16e2f7310dbb35495/src/bio2bel_expasy/database.py#L143

https://github.com/bio2bel/ec/blob/ba377388b0d3fe018b6826e16e2f7310dbb35495/src/bio2bel_expasy/database.py#L154

https://github.com/bio2bel/ec/blob/ba377388b0d3fe018b6826e16e2f7310dbb35495/src/bio2bel_expasy/database.py#L163

https://github.com/bio2bel/ec/blob/ba377388b0d3fe018b6826e16e2f7310dbb35495/src/bio2bel_expasy/database.py#L198

Similarly, other functions in the manager that take UniProt and ProSite identifiers should also use more descriptive variable names