All Element types are graph's inner classes

bio4j / angulillos

Java 8 library for strongly typed graph data

GNU Affero General Public License v3.0

7 stars 2 forks source link

All Element types are graph's inner classes #60

Closed laughedelic closed 8 years ago

eparejatobes commented 8 years ago

@laughedelic ping me if you need help here

laughedelic commented 8 years ago

@eparejatobes I have some more code that I haven't pushed yet. I'd like to discuss some things about it with you.

laughedelic commented 8 years ago

One important thing that I'm quite sure about: no matter how you refine types, use self-references, etc. if in, say, User you don't subclass Vertex inner class, then

Twitter<RV,RE>.User.Vertex
TypedGraph< Twitter<RV,RE>, RV,RE >.VertexType< Twitter<RV,RE>.User >.Vertex

are the same thing. i.e. User doesn't have its own specific Vertex inner class. But all types it depends on are fixed correctly.

I'm fine with it. As soon as the Vertex is made final, nothing bad can happen with it.

laughedelic commented 8 years ago

Actually, taking into account all this, I don't see any advantages of this approach over what we already have in #58...

laughedelic commented 8 years ago

I've tried moving things from the outer interfaces to the inner-inner classes and I can say that it doesn't help anything.

It doesn't help to have simpler types,
it doesn't solve the problem with inheritors not having their own inner class (if you don't extend it explicitly),
and it doesn't help with the difficutly in overriding things in the inner classes.