search

bio4j / angulillos

Java 8 library for strongly typed graph data
GNU Affero General Public License v3.0
7 stars 2 forks source link

all arity-specific methods are broken #78

Closed eparejatobes closed 8 years ago

laughedelic commented 8 years ago

😱

laughedelic commented 8 years ago

What happened?

eparejatobes commented 8 years ago

just pushed

eparejatobes commented 8 years ago

EdgeType needs to refer to itself in TypedGraph, otherwise you just know about it source and target. This is wrong: https://github.com/bio4j/angulillos/blob/7ca8381f7eb91c3a07bb9185edefa3e23f9f9293/src/main/java/com/bio4j/angulillos/TypedGraph.java#L216-L234

eparejatobes commented 8 years ago

That, or making on EdgeType class per Arity combination in TypedGraph

eparejatobes commented 8 years ago

There's a super-easy unsafe fix though, that could be enough

eparejatobes commented 8 years ago

@laughedelic doing this? if not, will do

laughedelic commented 8 years ago

So what's your plan?

eparejatobes commented 8 years ago

to fix it!