Closed eparejatobes closed 9 years ago
@pablopareja I did this for the Enzyme module, is pretty straightforward
it is actually nice, how we have things now I should say. :clap: :tophat:
@pablopareja put this on hold, I'm taking a different route
Ok...
@pablopareja I added a Scala test running EnzymeDB. Everything works fine but for the type definition part; they radically changed the behavior here in 0.5, and now VertexLabel
, EdgeLabel
etc are useless if you close the transaction from where you get them. This is just crazy. See
So basically we are left with only one option: use String
s everywhere when interfacing with Titan, and as types the corresponding xxxMakers; we will only call getName()
on them, using the overloaded addVertex(String label)
, addEdge(String label)
, ... methods.
I think I can finish this tomorrow.
OK :wink:
@pablopareja I did that change in bio4j/angulillos-titan#1 (moving to xxxMakers for types) and everything works smoothly now for EnzymeDB; run test
here inside sbt
. :+1:
Cool ! I just checked it out after pulling the changes and it's true :smiley: Should we then keep on updating the rest of modules to this new way of initialize the properties and labels?
@eparejatobes :question:
yes!
Ok! I'm getting to work on it then :space_invader:
@pablopareja let me check this
ok! :wink:
tests pass, LGTM
once bio4j/angulillos-titan#1 is ready