bio4j / bio4j-titan

Titan-specific bio4j implementation
https://github.com/bio4j/bio4j
6 stars 2 forks source link

Relationships/properties/nodes definition #8

Closed pablopareja closed 9 years ago

pablopareja commented 10 years ago

Hi!

I just started to implement the definition of relationships in the program InitBio4jTitan specifying cardinality and uniqueness consistency locks. There's something I'm not clear about which is what to do with properties definition. I'm afraid we should maybe define all of them explicitly?? :cold_sweat: :scream: Since we sort of already decided to deactivate automatic type creation I read it's recommended to do it explicitly. What do you think? Here's the link to the commit I'm referencing: d7faca9

laughedelic commented 10 years ago

One important concern here: all these definitions are done in InitBio4jTitan and I believe that it's wrong, because it's bad for modularity. I suggest to separate this file on the parts that correspond to Bio4j modules, so that particular properties/relations will be created only when they are needed. These parts of init can be separate (corresponding to each import program) or just added to the beginning of the import programs (which may be not so good for big parts like uniprot). I think, it will be also easier to maintain it this way. And of course it will simplify some things for the statika-bundles project. What do you think, @pablopareja?

pablopareja commented 10 years ago

mmm I'm not so sure about this being a good idea.... Besides, different modules partially share the same initialization requirements. @eparejatobes WDYT?

laughedelic commented 10 years ago

what is the shared part?

eparejatobes commented 10 years ago

We should separate all type definitions and module-specific init code into module-specific classes. And this should of course match bio4j/bio4j-model#5

We (@laughedelic and me) discussed it past Friday; @laughedelic prepare a short (10 min) talk about how this can be done and where it'd go (API modules etc) and we can see this tomorrow morning OK?

laughedelic commented 10 years ago

ok

pablopareja commented 10 years ago

OK, actually in the case it's done right it can be a pretty cool thing. Nice to see how all this is getting more professional every day! :smiley:

laughedelic commented 10 years ago

See bio4j/bio4j-modules#24

pablopareja commented 10 years ago

What do you want me to see there?

laughedelic commented 10 years ago

I just prepared a talk, as Edu said. For the meeting this morning. But we have problems with the internet in the office..

pablopareja commented 10 years ago

So then?

laughedelic commented 10 years ago

Tomorrow?

laughedelic commented 10 years ago

One suggestion here:

eparejatobes commented 10 years ago

agreed

pablopareja commented 10 years ago

OK :+1:

eparejatobes commented 9 years ago

closing