search

bio4j / dynamograph

GSoC 2014 project - a DynamoDB based graph DB
GNU Affero General Public License v3.0
4 stars 1 forks source link

Refactoring recomendations #40

Open laughedelic opened 10 years ago

laughedelic commented 10 years ago

Hi @alberskib! I just made some changes and left notes (sometimes questions). You can leave comments on the commit. Most of what I've done here is quite superficial refactoring. Maybe I don't get something and my changes are not suitable — just tell me.

eparejatobes commented 10 years ago

updated this to Properties everywhere

alberskib commented 10 years ago

@eparejatobes Thanks for update; Yes I even notice that you introduce some changes and publish them :) - now I have some problems because after update those libraries I have more or less 100 compilation errors (looks like problem with caches) - I will fix those problems and work on docs

alberskib commented 10 years ago

Hello @eparejatobes How is going with changes in scarp, type-sets and tabula? It is ready? How is your neck? I hope you get better today.

eparejatobes commented 10 years ago

much better thanks! I think you can start using all of them :) let me check out this and see how things are

alberskib commented 10 years ago

Great.

eparejatobes commented 10 years ago

hey @alberskib I got caught in a meeting and I just did something like what you did :+1:

eparejatobes commented 10 years ago

I'll comment on what I think can be done simpler

alberskib commented 10 years ago

Great - It still needs some work but every comment that makes code better is more than welcome :)

eparejatobes commented 10 years ago

nice @alberskib just some details :)

alberskib commented 10 years ago

@eparejatobes Could you tell me how to convert item to the record?

eparejatobes commented 10 years ago

You mean from item.Rep to record.Rep?

alberskib commented 10 years ago

Exactly

eparejatobes commented 10 years ago

IIRC item.Rep <: item.record.Rep