bio4j / dynamograph

GSoC 2014 project - a DynamoDB based graph DB
GNU Affero General Public License v3.0
4 stars 1 forks source link

scala model - Gene Ontology #7

Closed alberskib closed 10 years ago

alberskib commented 10 years ago

Implement scala model for GO. Please take into account experience and suggestion taken from actual java model (https://github.com/bio4j/bio4j/tree/master/src/main/java/com/bio4j/model/go) as well as new (bio4j/bio4j#40).

alberskib commented 10 years ago

@bio4j/dynamograph I think that GO model will be layered - there will be dynamoDB layer, scarph layer, as well as high level layer which will be provide clients with easy in use API. (layers could be expressed ie by class hierarchy, composition etc). Bio4j implementations based on neo4j and titanDb offers high level API written in java. As mentioned projects is used by some clients that could have some opinions regarding API (feedback) it will be great to gather such opinions in order to provide great model in scala.

alberskib commented 10 years ago

I am not sure whether I correctly used scarph lib so please take a look into it. The way I see how mentioned lib should be integrated is more or less like:

Actually there are couple of things that need to be discussed:

laughedelic commented 10 years ago

You say the right thing in your last point. Scarph-DynamoDB binding shouldn't be mixed with the GO scarph model. See my comment and take a look at the titan example again:

they are completely independent. And they are connected only in one place:

alberskib commented 10 years ago

Next commit still needs some improvements i.e Handling GOTermNamespace enum by AnyDynamoVertex#unsafeGetProperty etc. Those change will be in next commits

laughedelic commented 10 years ago

@alberskib cool :+1: for the last commit. looking forward for the next one ")

alberskib commented 10 years ago

@bio4j/dynamograph Can I merge this branch?

eparejatobes commented 10 years ago

OK @alberskib LGTM