search

bioDS / beast-phylonco

A BEAST2 package for single-cell cancer evolution
GNU Lesser General Public License v2.1
6 stars 2 forks source link

subproject names are confusing #20

Closed walterxie closed 2 years ago

walterxie commented 2 years ago

Hi @kche309 and @J-Moravec,

After Alexei reviewed the develop tutorial, he advised the subproject names were very confusing, which might imply the subfolders containing all of cores (e.g. lphy, beast2). I think they are confusing. I will change these 3 subfolders (sub-projects) into: phylonco-b2, phylonco-lphy, and phylonco-lb. Previously these names were defined by base names. In this change, I will remove the base names, so Gradle can use the subproject names for naming as the default.

Do you want me to create a branch for this change?

kche309 commented 2 years ago

Hi @walterxie I have also noticed this issue, especially if you are developing code it is easy to confuse it for beast2 core.

I would suggest renaming directories and jars to phylonco-beast, phylonco-lphy and phylonco-lphybeast.

Please create a branch for changes, and use git mv to do the renaming.

J-Moravec commented 2 years ago

Agree with Kylie, phylonco-beast etc. is better, there is no reason to be less expressive.

walterxie commented 2 years ago

Everything looks OK, including history.