set.py long description file name variation

biobakery / phylophlan

Precise phylogenetic analysis of microbial isolates and genomes from metagenomes

https://huttenhower.sph.harvard.edu/phylophlan

MIT License

123 stars 33 forks source link

set.py long description file name variation #95

Open erinpnewcomer opened 2 years ago

erinpnewcomer commented 2 years ago

Hi! The setup.py file calls the file 'readme.md' for the long description, but that file doesn't exist in the PyPi tarball. A similar file called PKG-INFO exists instead. I found this because I was creating a Spack package and the build failed for the Pypi version, but not the Github version.

fasnicar commented 2 years ago

Hi and sorry for the late reply. So, I looked around, and potentially that could be due to the wrong handling of markdown files. So I just added a .gitattributes file (0fb5cc022ac2ad52d7adeaaf130346c5bf996267) that might solve the issue, I'll check this with the next release. Thank you very much for reporting this and please, let me know if you should have any updates on this topic.

Many thanks, Francesco