Bioboxes-py should raise a BioboxError exception when the docker container returns a non-zero exit code.

bioboxes / bioboxes-py

Python library for creating and running bioboxes

2 stars 1 forks source link

Bioboxes-py should raise a BioboxError exception when the docker container returns a non-zero exit code. #31

Closed michaelbarton closed 7 years ago

michaelbarton commented 7 years ago

Currently bioboxes-py doesn't do anything with the error codes returned by docker containers. Ideally non-zero codes should be captured and a suitable exception with the biobox namespace should be raised.

michaelbarton commented 7 years ago

I think actually this may not necessary. The function did_exit_succcessfully can be used to check what the exit status is of the container. Anyone using the biobox.py library can use this method to check the container exit status. Instead I think the command line interface should be providing a suitable error message to the user in this instance. This is described in bioboxes/command-line-interface#112