search

biobricks-ai / bricktools

a set of tools for auditing bricks
2 stars 1 forks source link

Add arrow as a dependency to biobricks-r DESCRIPTION #3

Open Larsdegroot opened 1 year ago

Larsdegroot commented 1 year ago

When trying to run install_github("biobricks-ai/biobricks-r",dep=TRUE) the executing halted with the following error message:

Error: package or namespace load failed for ‘biobricks’:
 .onLoad failed in loadNamespace() for 'biobricks', details:
  call: library(arrow)
  error: there is no package called ‘arrow’
Error: loading failed
Execution halted

The arrow package is also missing from the DESCRIPTION file under imports. Adding it could resolve the installation issue.

tomlue commented 1 year ago

ok, the tricky thing about arrow is that the installation instructions are environment dependent. In the future we may allow many other file types to be distributed through biobricks, and the default loading mechanism may require different packages. If you're just going to use parquet then you wouldn't need the other stuff.

So I think we need a few different package types. And to resolve this issue we should just inform users that they need the arrow package to use the given asset, and ask if they would like to install it.

Does that solution work for you?