search

biobricks / bionet-2

The bionet web app
3 stars 2 forks source link

Favorites tab gets deleted when you delete a box that is in the favorites #131

Closed ccmeyer closed 7 years ago

ccmeyer commented 7 years ago

screen shot 2017-06-07 at 11 38 37 am I think that the deletion of the favorites tab in the work bench happens when I delete a box that I have added to the favorites. I would go into the local inventory tab, make a new box, give it a name, hit submit and add it to my favorites. I would then be able to see the box in the favorites tab. If I go back to the local inventory and then select and delete the box that I added to the favorites and then go back to the workbench page the favorites tab is gone. I took a screenshot of the console when I went back to the workbench and it says something about how it can't read "favorites."

I have been able to replicate this issue several times and found that if I delete a box that is not in the favorites nothing happens but every time that I have deleted one from the favorites it gets rid of the tab

Juul commented 7 years ago

AWESOME! Thanks for finding the cause of this :+1:

ccmeyer commented 7 years ago

No problem, I haven't had any luck recreating the other issues though

Juul commented 7 years ago

Should be fixed now. Give it a try?

ccmeyer commented 7 years ago

I just created a box added it to my favorites and deleted it and the favorites dropdown is still there so I think that you fixed it