search

biochem-fan / GLmol

A molecular viewer written in Javascript and WebGL
73 stars 28 forks source link

Updated to support threejs r69 #5

Closed dimin closed 9 years ago

dimin commented 9 years ago

Hi,

I updated GLmol to work with the latest threejs r69, it's no longer needed to use custom versions...

biochem-fan commented 9 years ago

Hello.

Thank you very much for your contribution. For the reasons I explained in https://github.com/biochem-fan/GLmol/pull/4, I keep using old Three.js. However, considering that many people do want the upgrade, I created a new branch called "newThreeJS". Could you please make a pull request into that?

dimin commented 9 years ago

I'm not sure that the size of ThreeJS is a compelling enough reason to keep the older branch. It's obviously a big problem when you already are using ThreeJS in your app to attempt loading the custom older version.

biochem-fan commented 9 years ago

Probably you are right. In future, I will make newThreeJS branch the trunk.