The current behaviour is (from comments in the above java file):
check that either both minimumColumn and maximumColumn are either present or missing, but not only 1 column present
check that each column is a valid number
check that maximumColumn is greater then the minimumColumn for each {@link Record}
We should only enforce the 2nd and 3rd items in the list above in this rule, and NOT the first. It is legitimate to have one value and not the other when we have columns specifying min and max number (and in fact, very common in biocode data).
If there is a case where we need both columns we can add another rule: RequireValueIfOtherColumn
In the MinMaxNumber rule at:
https://github.com/biocodellc/biocode-fims-commons/blob/091e2c5976d0ff615e8500436e64f984dfe1a2bf/src/main/java/biocode/fims/validation/rules/MinMaxNumberRule.java
The current behaviour is (from comments in the above java file):
We should only enforce the 2nd and 3rd items in the list above in this rule, and NOT the first. It is legitimate to have one value and not the other when we have columns specifying min and max number (and in fact, very common in biocode data).
If there is a case where we need both columns we can add another rule: RequireValueIfOtherColumn
John