search

biocodellc / geome-ui

MIT License
3 stars 4 forks source link

expeditionCode required for both Events AND Samples #275

Open ericcrandall opened 5 years ago

ericcrandall commented 5 years ago

I get validation errors when I upload data with multiple events if the expeditionCode is not included in both Samples and Events sheets.

Shouldn't it be a property of Event?

ericcrandall commented 5 years ago

It's also apparently required for Tissues

ewingrj commented 5 years ago

Is this for a multi-expedition upload? Or did you select a single expedition on the upload page?

Was this an error or warning? A screen shot of the actual error would be helpful.

expeditions are not a property of any of those entities, but instead a collection that those entites belong to.

ericcrandall commented 5 years ago

It was a multiple expedition upload.

Error shown in attached pic. I can circumvent it obviously by just adding the expedition code, but this might be confusing down the line.

The error in the pic about the identifiers is new. I didn't have that problem before. Some weird Excel thing no doubt. Screen Shot 2019-05-22 at 2 24 53 PM

jdeck88 commented 5 years ago

Try changing the format type on your ID column... i really hope you don't have id's like 4.110000000000000003!!

Re: the expeditionCode issue, i think we need better error text? i made an issue: https://github.com/biocodellc/geome-ui/issues/289 See if my proposed text in that issue makes any sense (and appreciate edits for clarity!)

John

On Wed, May 22, 2019 at 11:28 PM Eric Crandall notifications@github.com wrote:

It was a multiple expedition upload.

Error shown in attached pic. I can circumvent it obviously by just adding the expedition code, but this might be confusing down the line.

The error in the pic about the identifiers is new. I didn't have that problem before. Some weird Excel thing no doubt. [image: Screen Shot 2019-05-22 at 2 24 53 PM] https://user-images.githubusercontent.com/9354350/58210184-91d6e480-7c9d-11e9-9d47-10f617a16117.jpg

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/biocodellc/geome-ui/issues/275?email_source=notifications&email_token=AAIZ3ROINHVFQR63M4NKHU3PWW3HLA5CNFSM4HLV6XJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWAM3FA#issuecomment-494980500, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIZ3RLT72XVGFQXQDJBYPDPWW3HLANCNFSM4HLV6XJQ .

-- John Deck (541) 914-4739