biocommons / biocommons.seqrepo

non-redundant, compressed, journalled, file-based storage for biological sequences
Apache License 2.0
39 stars 35 forks source link

Make coding style consistent with hgvs / enforce black and pylint #108

Open holtgrewe opened 1 year ago

holtgrewe commented 1 year ago

There is much more to coding style than indentation and static error analysis with lint. However, these can be enforced automatically.

Looking at the CI files for hgvs, the following appear to be useful:

github-actions[bot] commented 1 year ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 1 year ago

This issue was closed because it has been stalled for 7 days with no activity.

jsstevenson commented 3 months ago

I don't necessarily want to close this yet, but we're currently trying to be more purposeful about basing things like styling off of what's defined in the template first. That's entailed a slow (still ongoing) rollout of changes across biocommons - we've made some decisions about configs but are taking our time to populate them out to the repos because we don't want to impact ongoing PR discussions. This repo is pretty clean, though, so we could probably get them done soon.

Broadly, unless there's a repo-specific configuration to implement, I think we generally want to form a consensus around linting/formatting/etc on the example repo first, and go from there.