search

biocommons / eutils

simplified searching, fetching, and parsing records from NCBI using their E-utilities interface
Apache License 2.0
58 stars 25 forks source link

closes #157: edge case results in error being thrown when extracting abstract text #158

Closed pmartin23 closed 6 years ago

pmartin23 commented 6 years ago

closes #157

reece commented 6 years ago

Looks good so far! Would you please also add a test?

Specifically, in tests/test_eutils_xmlfacades_pubmedarticle.py, add a new test function for pubmed id 29915538. You can use the previous test as a template. At the very least, the test should ensure that the abstract method works with something like assert "Semaglutide" in pa.abstract.

You can run the tests this with make test.

(Apologies if this is stuff you already know. You previous said that this was your first PR so I was assuming tips would help.)

Thanks for the contribution!

pmartin23 commented 6 years ago

Yes, of course - I'll add in the test now. Please don't apologise - those tips are super useful - thank you!

reece commented 6 years ago

Thanks @pmartin23! Congrats on your first PR!

I "squashed and merged" the commits so that these appear as a single commit. You may want to git pull origin master to sync your repo.

pmartin23 commented 6 years ago

How exciting! You're welcome, and thanks for your help.