biocommons / hgvs

Python library to parse, format, validate, normalize, and map sequence variants. `pip install hgvs`
https://hgvs.readthedocs.io/
Apache License 2.0
240 stars 94 forks source link

fix: projection issue for stop retained insertion (#707) #708

Closed holtgrewe closed 4 weeks ago

holtgrewe commented 11 months ago

Closes: #707

github-actions[bot] commented 10 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 10 months ago

This PR was closed because it has been stalled for 7 days with no activity.

github-actions[bot] commented 8 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

github-actions[bot] commented 8 months ago

This PR was closed because it has been stalled for 7 days with no activity.

holtgrewe commented 8 months ago

@reece ping

reece commented 7 months ago

This issue was closed by stalebot. It has been reopened to give more time for community review. See biocommons coding guidelines for stale issue and pull request policies. This resurrection is expected to be a one-time event.

github-actions[bot] commented 6 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

holtgrewe commented 6 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

Ping.

korikuzma commented 6 months ago

@holtgrewe thank you for your PR and sorry about the delay. It appears that your branch is out of date. Would you please pull changes from main and resolve merge conflicts? Once that's done and tests are passing, please comment to let us know.

github-actions[bot] commented 5 months ago

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.

holtgrewe commented 5 months ago

Stay alive until I return to office please.

holtgrewe commented 2 months ago

@korikuzma I found the time to update this finally. I now had to fix one new test.

As a reminder for myself, here is how I ran the test and re-created the HGVS_CACHE.

UTA_DB_URL=postgresql://anonymous:anonymous@uta.biocommons.org:5432/uta/uta_20210129 HGVS_CACHE_MODE=learn pytest -vv --record-mode=rewrite -s