Add some more tests

[cmorse]

So, based on your comments, which of these tests should I salvage?

[biocomp]

So, based on your comments, which of these tests should I salvage?

• def "Attributes must have name specified"() -> Remove, has equivalent: "attribute() with empty type fails"

• def "Attributes must have type specified"() -> Remove, has equivalent: "attribute() with empty name fails"

• def "Attributes must have a type in ['string', 'enum', 'number']"() - Remove, has equivalent between two tests.

• def "Attribute of type 'enum' must have possibleValues with size > 1 provided"() - Update equivalent test "attribute() with 'enum' type fails if doesn't have 'possibleValues' (possibleValues = '#possibleValues')", that doesn't check for size > 1

• def "Attribute of type 'string' or 'number' must not have possibleValue provided"() - Update my test "attribute() with non-enum type can't have 'possibleValues'" that covers only number type.

• def "Check that valid attributes succeed"() - Update equivalent test "attribute() with valid type = '#type' can be read" which is not as exhaustive.

• def "Valid capabilities pass"() - Remove, has equivalent: "Valid capability '#capability' in definition() can be read"

• def "Invalid capabilities fail"() - Remove or update. Equivalent: "Invalid capability in definition() fails" (doesn't check for null or empty string though - so maybe update it instead).

• def "Valid commands pass"() - Remove, somewhat equivalent to "command() data type (#type) is valid"

• def "Valid commands must have a methodName != null"() - Update "command() fails with invalid data type" which is not checking for null

• def "Inputs fail without all required values"() - Remove, equivalent: "input(#inputDef) fails when name or type are missing"

• def "Inputs with invalid extra args fail"() - No equivalent. Add to DevicePreferencesReaderTest.groovy

• def "Valid inputs pass"()/def "Valid inputs with all extra args pass"() - Remove, equivalent: def "Calling input() with every valid option succeeds"()

• def "Fingerprints with invalid extra args fail"() - Perhaps add this test to DeviceDefinitionsReaderTest.groovy. Not sure if I test requirement of all the keys not being present.

• def "Valid fingerprints with all extra args pass"() - Remove, equivalent: "Valid fingerprint(#fingerprintText) is accepted")

[cmorse]

Alright, thanks. I'll work on that when I get a chance

[cmorse]

@biocomp I finally had some time to work on this. I think it's ready to go.

[cmorse]

@biocomp I got around to fixing that last issue