search

biocompute-objects / BCO_Documentation

Repository for documentation to support the IEEE 2791-2020 standard. Please see our home page for communications/publications:
http://biocomputeobject.org/
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Keywords should not be nested #12

Closed stain closed 6 years ago

stain commented 6 years ago

The keywords is for some reason nested as a map to lists.

      "keywords": [
            {
                "key": "search terms",
                "value": [
                    "HCV1a", 
                    "Ledipasvir", 
                    "antiviral resistance", 
                    "SNP", 
                    "amino acid substitutions"
                ]
            }
        ]

It is unclear what is the meaning of nestings like search terms and where such keys should be defined.

Keywords are normally not structured, so I would change this to a flat listing:

      "keywords": [
                    "HCV1a", 
                    "Ledipasvir", 
                    "antiviral resistance", 
                    "SNP", 
                    "amino acid substitutions"
        ]
HadleyKing commented 6 years ago

agreed.

mr-c commented 6 years ago

Fixed in https://github.com/biocompute-objects/BCO_Specification/commit/d0aa195bdbd64ce43291277affcbec7f02cb56a5