search

biocompute-objects / BCO_Documentation

Repository for documentation to support the IEEE 2791-2020 standard. Please see our home page for communications/publications:
http://biocomputeobject.org/
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

Explain FHIR extension #20

Closed stain closed 6 years ago

stain commented 6 years ago

fhir extension only shown by example, the keys are not explained. The camel_Casing is a bit inconsistent.

James Jones suggested:

Can address the camel_Case issues and describe the keys as follows:

FHIR_endpoint is a string containing the URL of endpoint of the FHIR server containing the resource.

FHIR_resource is a string containing the type of resource used. A full list of permitted FHIR resources is available at http://hl7.org/fhir/resourcelist.html.

FHIR_ID is a string containing the server-specific identifier for the resource instance.

The full URL of each referenced FHIR object is the combined address of the form: FHIR_endpoint/FHIR_resource/FHIR_ID

stain commented 6 years ago

Camel_underscore_Casing is inconsistent, should these perhaps all be lowercase?

jpat1546 commented 6 years ago

Reopening issue until all inconsistencies have been addressed.

mr-c commented 6 years ago

@jpat1546 which commit(s) fixed the remaining inconsistencies?

jpat1546 commented 6 years ago

@jpat1546 which commit(s) fixed the remaining inconsistencies?

https://github.com/biocompute-objects/BCO_Specification/commit/6d5b93ccb0c4bff0838400b642bb430a7f141695

https://github.com/biocompute-objects/BCO_Specification/commit/d4a8333