biocompute-objects / BCO_Documentation

Repository for documentation to support the IEEE 2791-2020 standard. Please see our home page for communications/publications:
http://biocomputeobject.org/
BSD 3-Clause "New" or "Revised" License
16 stars 12 forks source link

release_1.4.0 #86

Closed HadleyKing closed 2 years ago

HadleyKing commented 4 years ago
stain commented 4 years ago

We also need to remove or update the schema files to match exactly https://gitlab.com/IEEE-SA/2791/ieee-2791-schema (including their LICENSE/COPYRIGHT). In particular notice:

"spec_version": "https://w3id.org/2791/"
stain commented 4 years ago

I checked if the user guide is updated to match IEEE 2791-2020, but https://github.com/biocompute-objects/BCO_Specification/blob/1.4.0/docs/bco-domains.md#bco-domains says 1.3.0 in its spec_version.

The user guide no longer link or include the JSON schema files from https://gitlab.com/IEEE-SA/2791/2791-schema/

Many of the other pages have too strong recommendations compared to the standard, e.g. ETag mentions SHA256, but that would just be one of many ways to calculate it.

References to xref in https://github.com/biocompute-objects/BCO_Specification/blob/1.4.0/docs/usability-domain.md seem unfounded from IEEE spec/schema as usability_domain.json just say free text, while we find in user guide:

The usability_domain can accept template language to indicate values from the external_references.

This template language is not defined by IEEE 2791.

So overall these kind of general guidances or best practices (which do not exist in IEEE standard) should be separated out from guidance on what is required from the specification.

HadleyKing commented 4 years ago

@stain I posted an issue about the URLs. Not sure if Josh has seen it. @kee007ney or I will try to reach out again.

        "spec_version": {
            "type": "string",
            "description": "Version of the IEEE-2791 specification used to define this document",
            "examples": [
                "https://w3id.org/2791/"

The current schema files are a direct copy of the IEEE files, but they need to be addressed. https://gitlab.com/IEEE-SA/2791/2791-schema/-/blob/master/2791object.json#L120