search

biocompute-objects / bco_editor

A web application that can be used to create and edit BioCompute objects based on BioCompute schema described in the BCO specification document.
https://portal.aws.biochemistry.gwu.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Parametric, Extension, and Error Domains prevent advancing to save BCO, but they should be optional #113

Closed kee007ney closed 4 years ago

kee007ney commented 4 years ago

In the Editor, Parametric, Extension, and Error Domains are all required and will not let the user advance. None of these are required domains in the current BCO spec.

The error raised with Extension Domain is that it needs to be formatted as an array, but it gives this error even if nothing is there, so it's effectively making this field required. This error should only come up if there is content in the Extension Domain. If it's empty, it should let the BCO pass.

ITsolution-git commented 4 years ago

https://github.com/biocompute-objects/bco_editor/commit/000a3c8664a0425918cfb6078727729d0d8773b8

jpat1546 commented 4 years ago

Still requiring the Parametric and Extension domains :

image

image

jpat1546 commented 4 years ago

Domains no longer required- users can save their BCO with no input in the PD, Error Domain, and Extension Domain.

Issue will be completely resolved once asterisk* is removed from the PD header. Thanks!

jpat1546 commented 4 years ago

Parametric domain still being required in 3.0.2

jpat1546 commented 4 years ago

closing and splitting into separate issues. #146