biocompute-objects / bco_editor

A web application that can be used to create and edit BioCompute objects based on BioCompute schema described in the BCO specification document.
https://portal.aws.biochemistry.gwu.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Share option adjacent to "Edit Object" #27

Closed jpat1546 closed 4 years ago

jpat1546 commented 5 years ago

While this is housed in Milestone 1.5, the deadline (realistically) can't be Sept 5. I think we should aim for Sept 23? @openbox-bio let me know how reasonable that deadline is!

This will address 2 issues:

  1. Allowing collaborators to modify/edit an existing object (even to just view it during an embargo period). If we create a “Share” button- they can select permissions for the individual they are sharing with, so long as that individual has an editor account. permission options : read only (for collaborators during an embargo period), modify, etc.
jpat1546 commented 5 years ago

Splitting this ticket into 2- share (#27) and version (#34)

jpat1546 commented 5 years ago

Share feature is there! While testing, I received an exception error when attempting to provide more than one individual with read-write permissions. (First individual- permission successfully granted. Second individuals- exception-error-SAVQVQ)

image

openbox-bio commented 5 years ago

Thanks. Working on it now. -Anjan

“Don't be satisfied with stories, how things have gone with others.

Unfold your own myth.” ― Rumi,

========================================

On Wed, Sep 25, 2019 at 6:10 PM Janisha Patel notifications@github.com wrote:

Share feature is there! While testing, I received an exception error when attempting to provide more than one individual with read-write permissions. (First individual- permission successfully granted. Second individuals- exception-error-SAVQVQ)

[image: image] https://user-images.githubusercontent.com/23385872/65643355-93a01400-dfbf-11e9-91d4-341e39f49e65.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/biocompute-objects/bco_editor/issues/27?email_source=notifications&email_token=AESJ6DQZ6YWNOA6RHE6E2X3QLPOWFA5CNFSM4ISHD6TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7TSUNA#issuecomment-535243316, or mute the thread https://github.com/notifications/unsubscribe-auth/AESJ6DTACJ6Z2PYSP54HMTDQLPOWFANCNFSM4ISHD6TA .

jpat1546 commented 5 years ago

Awesome. In addition- would you be able to view existing permissions? For ex: permissions

jpat1546 commented 5 years ago

Still unable to share read/write permissions with more than one user. adding user#1: image

adding user#2: image

jpat1546 commented 5 years ago

Ok, so we've been able to select multiple users to share with. Hadley shared BCO_000009 with me (ReadWrite), but I only have read-only permissions.... image

and it seems to be parsing the string that is my name into a list of creators... image

openbox-bio commented 5 years ago

I shared BCO_000015 with the three of you with varying permissions. Permissions are being given correctly. Names are being listed correctly as well. Hadley will you please share with Janisha again and let me know if the problem persists? -Anjan

“Don't be satisfied with stories, how things have gone with others.

Unfold your own myth.” ― Rumi,

========================================

On Thu, Sep 26, 2019 at 4:00 PM Janisha Patel notifications@github.com wrote:

Ok, so we've been able to select multiple users to share with. Hadley shared BCO_000009 with me (r/w permissions), and I only have read only.... [image: image] https://user-images.githubusercontent.com/23385872/65720784-ae818f80-e076-11e9-954b-6ed995e4bcd8.png

and it seems to be parsing the string that is my name into a list of creators... [image: image] https://user-images.githubusercontent.com/23385872/65720661-6bbfb780-e076-11e9-9ac1-57074e467dac.png

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/biocompute-objects/bco_editor/issues/27?email_source=notifications&email_token=AESJ6DUPADXZJOWDXBQUSP3QLUIEBA5CNFSM4ISHD6TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WZGSA#issuecomment-535663432, or mute the thread https://github.com/notifications/unsubscribe-auth/AESJ6DVLFQUZLUUWWU5G3O3QLUIEBANCNFSM4ISHD6TA .

jpat1546 commented 5 years ago

@HadleyKing please share BCO_000015 with me again. Thanks!

carmstrong1gw commented 4 years ago

Void, moved to API security doc.