search

biocompute-objects / bco_editor

A web application that can be used to create and edit BioCompute objects based on BioCompute schema described in the BCO specification document.
https://portal.aws.biochemistry.gwu.edu/
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Indicate field responsible for error message #28

Closed jpat1546 closed 4 years ago

jpat1546 commented 5 years ago

When a user is unable to save due to a Regex issue, in addition to the error message there should be an alert next to the responsible field. Ex:

Screen Shot 2019-08-29 at 5 56 48 PM

jpat1546 commented 5 years ago

If possible, I think it's important we build this feature in before students use the Editor. So while I think the tentative deadline should be Sept 20, I'll leave that to @kee007ney to decide for his workshop talk

openbox-bio commented 5 years ago

Good point. Will talk to my sub and see if we can squeeze this in before September 5th.

jpat1546 commented 5 years ago

Awesome, thanks Anjan!

openbox-bio commented 5 years ago

Implemented on test. Can you please check?

jpat1546 commented 5 years ago

image Ok, awesome that there's now a field-specific alert. The only issue is that since the checksum value is generated automatically and are not input by users, I'm unsure why this is the error message appearing? Maybe I'm misunderstanding, but let's definitely discuss this today on our call.

openbox-bio commented 5 years ago

OK, am on call. -Anjan

“Don't be satisfied with stories, how things have gone with others.

Unfold your own myth.” ― Rumi,

========================================

On Thu, Sep 5, 2019 at 4:19 PM Janisha Patel notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/23385872/64377260-0d179880-cff8-11e9-9d54-bb0de72e2621.png Ok, awesome that there's now a field-specific alert. The only issue is that since the checksum value is generated automatically and are not input by users, I'm unsure why this is the error message appearing? Maybe I'm misunderstanding, but let's definitely discuss this today on our call.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/biocompute-objects/bco_editor/issues/28?email_source=notifications&email_token=AESJ6DRCRETGS3KMPRRUN6DQIFST3A5CNFSM4ISHHCG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6AUA3A#issuecomment-528564332, or mute the thread https://github.com/notifications/unsubscribe-auth/AESJ6DVYUC7KW6MDN25W77LQIFST3ANCNFSM4ISHHCGQ .

openbox-bio commented 5 years ago

Please retest this. I believe we have completed this.

jpat1546 commented 5 years ago

Ok will do

jpat1546 commented 5 years ago

Checked- when there's an invalid version format- the error is shown as a new page rather than error message image vs image (Left the version field blank, and when attempting to save, the top pic shows the new page. Rather than this, it would be more functional to generate an error message on the Object's page, as was happening before)

carmstrong1gw commented 4 years ago

Void, already fixed.