search

bioconda / bioconda-extended-base-image

An extended docker container for cases where the busybox image is too limited.
MIT License
1 stars 1 forks source link

Dockerfile testing? #5

Open mbargull opened 7 years ago

mbargull commented 7 years ago

Build statuses can be checked manually at https://hub.docker.com/r/bioconda/extended-base-image/builds/. But is it possible to use some CI to automatically check whether the Dockerfile was successfully build for a commit / PR? Or are there notifications from Docker Hub which could be used? If an image could not be build, a Bioconda recipe build will fallback to a previous version. Hence the failed build won't get noticed when creating recipes which depend on the image.

daler commented 7 years ago

Wow, looks like there are no notifications, and the only webhook available is for when an image is pushed. Kind of surprising.

I guess one option could be to build the image on the fly, since the extended image is not used very frequently and the time hit might be acceptable. Another option could be to scrape the HTML from dockerhub looking for the last build item. Both solutions are very ugly though.

bgruening commented 7 years ago

@johanneskoester can you add me to the dockerhub organisation. I will follow this and subscript to it. There are notifications which we can follow, but honestly I hope we will not build this image very often.

johanneskoester commented 7 years ago

@bgruening added you. Is ithis about testing this base image? We can simply do this via travis, right?

mbargull commented 7 years ago

This is mainly/partially about testing the build of this images, which could be done via Travis CI, yes. But in the optimal case we would not only test whether the image can be build, but also if it was successfully built and made available on Docker Hub. This might be problematic due to what @daler's found:

Wow, looks like there are no notifications, and the only webhook available is for when an image is pushed

If it's not possible to define webhooks in Docker Hub for build success/failure, then that's not optimal, but as @bgruening said:

but honestly I hope we will not build this image very often.

Being able to write tests which would be executed by Travis for this image could be nice, though.

bgruening commented 7 years ago

Hi, I do get notifications for my own images if they fail, I hope I do get them now for this image as well. Either way I will keep an eye on this :)