search

bioconda / bioconda-recipes

Conda recipes for the bioconda channel.
https://bioconda.github.io
MIT License
1.64k stars 3.26k forks source link

Conda ignores my python version #45213

Open ekushele opened 9 months ago

ekushele commented 9 months ago

Hello,

I'm trying to create a new bioconda recipe, here The tests fails, due to python version < 3.

I specially specified python >3.6, so why conda ignores my python version?

ekushele commented 9 months ago

How can I get a review of this recipe?

martin-g commented 9 months ago

Your way of checking out the code in build.sh is strange. Any reason why you do this ?

About your problem: I guess it is because you use python at https://github.com/bioconda/bioconda-recipes/pull/44915/files#diff-7c5ab819418dba1f2f764c9aa3588841dd02fd29552b2c6fdd2de28007c32b79R9-R10. You could try to use python3 instead. But I'd recommend you to take a look at the other Python based recipes and rework yours to use build.script and source.url instead of source.path

https://github.com/bioconda/bioconda-recipes/pull/44915/files#diff-7c5ab819418dba1f2f764c9aa3588841dd02fd29552b2c6fdd2de28007c32b79R9-R10 (requirements.build) should contain only compilers (c, c++, fortran) and build tools (make, cmake). Anything else (even interpreters like python) should be in requirements.host

ekushele commented 9 months ago

Your way of checking out the code in build.sh is strange. Any reason why you do this ?

About your problem: I guess it is because you use python at https://github.com/bioconda/bioconda-recipes/pull/44915/files#diff-7c5ab819418dba1f2f764c9aa3588841dd02fd29552b2c6fdd2de28007c32b79R9-R10. You could try to use python3 instead. But I'd recommend you to take a look at the other Python based recipes and rework yours to use build.script and source.url instead of source.path

I removed the python --version. The python setup.py is part of compiling the code.

https://github.com/bioconda/bioconda-recipes/pull/44915/files#diff-7c5ab819418dba1f2f764c9aa3588841dd02fd29552b2c6fdd2de28007c32b79R9-R10 (requirements.build) should contain only compilers (c, c++, fortran) and build tools (make, cmake). Anything else (even interpreters like python) should be in requirements.host

Thank you for this comment. Done