After reviewing this and tracking down all the various moving parts, it's really unclear how the various docker images are specified throughout all our machinery. Explicit and implicit env vars set at various times, sometimes overridden by default args, sometimes not, sometimes hard-coded deep in bioconda-utils. Needs a refactor, where everything gets specified just once in bioconda-common and used everywhere. That's for another day though...
Port the fixes in f48280167a31cc87192e0a9ce729de935d702990, which were in
pkg_test.py, toupload.pyas well.ping @bgruening this is what was causing that strangely different behavior in
mulled-build'sbuild-and-testandpushover in https://github.com/bioconda/bioconda-recipes/pull/43995.After reviewing this and tracking down all the various moving parts, it's really unclear how the various docker images are specified throughout all our machinery. Explicit and implicit env vars set at various times, sometimes overridden by default args, sometimes not, sometimes hard-coded deep in bioconda-utils. Needs a refactor, where everything gets specified just once in bioconda-common and used everywhere. That's for another day though...