Closed wasade closed 8 years ago
Not clear to me why this failed the first go, but hopefully goes through this time.
Unsure what's going on here as the failure is associated with a missing path, however the path appears to exist and is valid here. Will investigate...
Passing. Ready for review
Just a general comment: it's a bit weird to be hiding so much code. I understand it's for the general public so black boxing it is probably for the best, just makes review a bit harder.
It's not hidden as the repo is open. Putting the methods into the notebook has the added challenge that it's not possible to unit test those methods. And, the overload of information presented to the user is large.
Fair. Also :+1:
thanks!
On Thu, Oct 22, 2015 at 11:08 AM, Yoshiki Vázquez Baeza < notifications@github.com> wrote:
Merged #165 https://github.com/biocore/American-Gut/pull/165.
— Reply to this email directly or view it on GitHub https://github.com/biocore/American-Gut/pull/165#event-442891814.
This includes #164, please do not review/merge until #164 has gone in.